feat(language-service): auto insert feature does not abstract selection #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous auto insertion implementation,
@volar/vscodealways issued requests with the end position of the changed range as a parameter. Based on whether the current selections include the end position of the changed range, it determines whether to insert the text into the selections or the end position of the changed range.Now it is changed to always issue requests with the selection position and always insert the text into the selections.
LanguageServicePluginare responsible for determining whether the selection is at the end position of the changed range to determine whether to provide auto insert text.This will resolve the limitation of not being able to achieve vuejs/language-tools#4140 downstream.